Re: [Qemu-trivial] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

[Andreas Färber]

Am 02.02.2013 18:17, schrieb Peter Maydell:
> Add explicit braces round an empty for-loop body; this fits
> QEMU style and is easier to read than an inconspicuous semicolon
> at the end of the line. It also silences a clang warning:
> 
> disas/i386.c:4723:49: warning: for loop has empty body [-Wempty-body]
>           for (i = 0; tmp[i] == '0' && tmp[i + 1]; i++);
>                                                        ^
> disas/i386.c:4723:49: note: put the semicolon on a separate line to silence 
> this warning [-Wempty-body]
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This is the only clang warning on MacOSX apart from the ones about
> deprecated features in audio/coreaudio.c and ui/cocoa.m, which is why
> I think it's worth zapping despite it being a style issue in one of the
> bits of disassembler code we got from binutils and which aren't generally
> in QEMU style.
> 
> checkpatch complains about the non-multiple-of-4 indent:
> WARNING: suspect code indent for conditional statements (10, 10)
> #27: FILE: disas/i386.c:4723:
> +          for (i = 0; tmp[i] == '0' && tmp[i + 1]; i++) {
> +          }
> 
> but I didn't see any value in reindenting the whole function just to
> shut it up.
> 
> At some point in the 1.5 cycle maybe we could update the code to avoid
> the deprecated MacOS functions and then we could enable warnings-are-errors
> on MacOS too.

On v10.5.8 I'm seeing some redundant declaration warnings from
disas/s390.c and assumed we wouldn't want to fix/workaround the disas
stuff. Same for some exynos4 file.

Also some uninitialized buf2 in the Realtek NIC or so.

And test-thread-pool breaks due to undefined ___sync_fetch_and_add and
___sync_val_compare_and_swap.

With my setup long broken due to pixman, we never made any progress
fixing the main() mess - Stefan W. replaced asprintf in the command line
code but I'd rather get rid of that in some way similar to here:
http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg03983.html

Cheers,
Andreas