[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] get_tmp_filename: add explicit e
Re: [Qemu-trivial] [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message
Mon, 04 Feb 2013 14:48:28 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2
Am 04.02.2013 14:33, schrieb Fabien Chouteau:
> On 02/04/2013 01:24 PM, Markus Armbruster wrote:
>> Good error reporting is hard. Knowledge about the error and its context
>> gets lost as you move up the call chain. Knowledge about how to report
>> errors gets lost as you move down.
> You're right, and in my opinion, no error reporting is the worst case.
The best solution would be to pass an Error **errp argument and use
error_setg() on it, as done for visitors and QOM. Then the caller can
decide whether to pass NULL and the callee can report detailed errors.
Invasive change obviously and thus not suitable for 1.4.
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg