[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-trivial] [PATCH] pci_host: Drop write-only address_space field |
|
Date: |
Fri, 1 Mar 2013 18:50:24 +0000 |
On 1 March 2013 18:33, Andreas Färber <address@hidden> wrote:
> Am 01.03.2013 17:57, schrieb Peter Maydell:
>> The address_space field of PCIHostState was only ever written, never used.
>> Drop it completely.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> Reviewed-by: Andreas Färber <address@hidden>
Incidentally I suspect you could if you liked get rid of all
the uses of PCIHostState in prep.c (and the #include of pci_host.h),
since it's now only using &pcihost->busdev as an opaque way of
saying SYS_BUS_DEVICE(dev)).
-- PMM