Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/4] m25p80: Fix debug messages.

[Edgar E. Iglesias]

On Wed, Apr 03, 2013 at 02:09:16PM +1000, Peter Crosthwaite wrote:
> Some dodgy casts were making a mess of these msgs.


Hi Peter

> 
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> 
>  hw/m25p80.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/m25p80.c b/hw/m25p80.c
> index 55e9d0d..34b476b 100644
> --- a/hw/m25p80.c
> +++ b/hw/m25p80.c
> @@ -538,15 +538,15 @@ static uint32_t m25p80_transfer8(SSISlave *ss, uint32_t 
> tx)
>      switch (s->state) {
>  
>      case STATE_PAGE_PROGRAM:
> -        DB_PRINT("page program cur_addr=%lx data=%x\n", s->cur_addr,
> -                 (uint8_t)tx);
> +        DB_PRINT("page program cur_addr=%lx data=%x\n", 
> (unsigned)s->cur_addr,

Shouldn't this be using PRIx64 for cur_addr?


> +                 (unsigned)(uint8_t)tx);
>          flash_write8(s, s->cur_addr, (uint8_t)tx);
>          s->cur_addr++;
>          break;
>  
>      case STATE_READ:
>          r = s->storage[s->cur_addr];
> -        DB_PRINT("READ 0x%lx=%x\n", s->cur_addr, r);
> +        DB_PRINT("READ 0x%lx=%x\n", (unsigned)s->cur_addr, (unsigned)r);


same here.


>          s->cur_addr = (s->cur_addr + 1) % s->size;
>          break;
>  
> -- 
> 1.7.0.4
> 
>