[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly in
Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h
Wed, 01 May 2013 19:29:34 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
Am 01.05.2013 19:09, schrieb Michael Tokarev:
> 30.04.2013 06:59, liguang wrote:
>> Signed-off-by: liguang <address@hidden>
>> translate-all.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
> Hmm. Does we require S-o-b line even for such a trivial (but nevertheless
> important) stuff?
If it's missing, author can either reply with Signed-off-by - if you're
willing to fix it up - or resend.
And whenever you pick up patches, you sign them off as well.
> Also, Peter, does your followup email mean your Rewieved-by should be added
No, generally not if it was not explicitly given. Exception from the
rule: We have allowed to turn an informal "ack" into an Acked-by.
Thanks for taking over qemu-trivial!
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg