qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] memory: Replace open-coded memory_region_is_r


From: Jan Kiszka
Subject: Re: [Qemu-trivial] [PATCH] memory: Replace open-coded memory_region_is_romd
Date: Tue, 07 May 2013 16:17:40 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2013-05-06 18:26, Paolo Bonzini wrote:
> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>> Improves readability.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>  translate-all.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..0d84b0d 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>>      section = phys_page_find(address_space_memory.dispatch,
>>                               addr >> TARGET_PAGE_BITS);
>>      if (!(memory_region_is_ram(section->mr)
>> -          || (section->mr->rom_device && section->mr->readable))) {
>> +          || memory_region_is_romd(section->mr))) {
>>          return;
>>      }
>>      ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>
> 
> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.

Great, thanks.

> 
> Any volunteers for co-maintaining it? :)

Raising my hand, but not without remarking that I have some bandwidth
issue ATM. But I will try my best.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]