[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] osdep.h: include sys/types.h for

From: Igor Mitsyanko
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition
Date: Fri, 10 May 2013 19:40:08 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 05/10/2013 07:24 PM, Peter Maydell wrote:
On 10 May 2013 16:16, Igor Mitsyanko <address@hidden> wrote:
This fixes build for mingw32

Signed-off-by: Igor Mitsyanko <address@hidden>
  include/qemu/osdep.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 42545bc..17946a3 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -163,6 +163,8 @@ int qemu_create_pidfile(const char *filename);
  int qemu_get_thread_id(void);

  #ifndef CONFIG_IOVEC
+#include <sys/types.h>
This is quite a long way down to have a system #include.

Can we just take the existing include of sys/types.h at
the top of the file out of its current #ifdef __OpenBSD__
guard ?

(http://hacks.owlfolio.org/header-survey/ has a full row
of greens for sys/types.h so this should be safe.)

-- PMM

Nice link.
Long way, yes, but there's "#include <sys/uio.h>" even further down in this file. But I guess taking existing sys/types.h is still better, I'll resend it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]