[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH (trivial)] remove some double-inc
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH (trivial)] remove some double-includes |
Date: |
Tue, 14 May 2013 18:15:16 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 |
14.05.2013 15:30, Peter Maydell wrote:
> On 14 May 2013 12:18, Michael Tokarev <address@hidden> wrote:
>> Some source files #include the same header more than
>> once for no good reason. Remove second #includes in
>> such cases.
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..a18bf55 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -52,21 +52,20 @@
>> #include <libutil.h>
>> #endif
>> #endif
>> #else
>> #include "exec/address-spaces.h"
>> #endif
>> #include "qemu/timer.h"
>>
>> #include "exec/cputlb.h"
>> #include "translate-all.h"
>> -#include "qemu/timer.h"
>
> There's already been a patch on the list for this one:
> http://patchwork.ozlabs.org/patch/240540/
>
Yes I know Peter, and actually this is the patch which prompte
me to look for other places. The person in question does not
reply (so far), so I thought maybe cleaning up more duplicates
is a good idea, or else the patch will just stuck.
/mjt