[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 4/5] libcacard/vreader.c: fix possible NULL derefe
From: |
Alon Levy |
Subject: |
[Qemu-trivial] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference |
Date: |
Tue, 4 Jun 2013 16:23:38 -0400 |
Reported by Coverity:
Error: FORWARD_NULL (CWE-476):
qemu-1.5.0/libcacard/vreader.c:267: cond_false: Condition "card == NULL",
taking false branch
qemu-1.5.0/libcacard/vreader.c:269: if_end: End of if statement
qemu-1.5.0/libcacard/vreader.c:272: cond_false: Condition "apdu == NULL",
taking false branch
qemu-1.5.0/libcacard/vreader.c:275: else_branch: Reached else branch
qemu-1.5.0/libcacard/vreader.c:280: cond_false: Condition "response", taking
false branch
qemu-1.5.0/libcacard/vreader.c:284: if_end: End of if statement
qemu-1.5.0/libcacard/vreader.c:280: var_compare_op: Comparing "response" to
null implies that "response" might be null.
qemu-1.5.0/libcacard/vreader.c:286: cond_true: Condition "card_status ==
VCARD_DONE", taking true branch
qemu-1.5.0/libcacard/vreader.c:287: cond_true: Condition "card_status ==
VCARD_DONE", taking true branch
qemu-1.5.0/libcacard/vreader.c:288: var_deref_op: Dereferencing null pointer
"response".
Signed-off-by: Alon Levy <address@hidden>
---
libcacard/vreader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/vreader.c b/libcacard/vreader.c
index 5793d73..60eb43b 100644
--- a/libcacard/vreader.c
+++ b/libcacard/vreader.c
@@ -260,7 +260,7 @@ vreader_xfr_bytes(VReader *reader,
{
VCardAPDU *apdu;
VCardResponse *response = NULL;
- VCardStatus card_status;
+ VCardStatus card_status = VCARD_FAIL;
unsigned short status;
VCard *card = vreader_get_card(reader);
--
1.8.2.1
- [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Alon Levy, 2013/06/04
- [Qemu-trivial] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths, Alon Levy, 2013/06/04
- [Qemu-trivial] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference,
Alon Levy <=
- [Qemu-trivial] [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable, Alon Levy, 2013/06/04
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Peter Maydell, 2013/06/04
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Eric Blake, 2013/06/04
- Re: [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Michael Tokarev, 2013/06/05
- Re: [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block, Michael Tokarev, 2013/06/12