Re: [Qemu-trivial] [Qemu-devel] [PATCH] block/m25p80: Update Micron entries

[Peter Crosthwaite]

Hi Ed,

On Wed, Jun 5, 2013 at 1:59 AM, Ed Maste <address@hidden> wrote:
> - Split 32Mb and 256Mb parts into a11 and a13 variants.
> - Add the 4K sector flag to the 128Mb parts.  (These entries were taken from
>   the Linux kernel list, which is missing the flag.)
> - Fill out the table of sizes with entries for 64Mb parts.
>
> Prodded by Peter Crosthwaite.
>
> Signed-off-by: Ed Maste <address@hidden>
> ---
>  hw/block/m25p80.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index a927a6b..8c3b7f0 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -123,10 +123,14 @@ static const FlashPartInfo known_devices[] = {
>      { INFO("mx25l25655e", 0xc22619,      0,  64 << 10, 512, 0) },
>
>      /* Micron */
> -    { INFO("n25q032a",    0x20bb16,      0,  64 << 10,  64, ER_4K) },
> -    { INFO("n25q128a11",  0x20bb18,      0,  64 << 10, 256, 0) },
> -    { INFO("n25q128a13",  0x20ba18,      0,  64 << 10, 256, 0) },
> -    { INFO("n25q256a",    0x20ba19,      0,  64 << 10, 512, ER_4K) },
> +    { INFO("n25q032a11",  0x20bb16,      0,  64 << 10,  64, ER_4K) },
> +    { INFO("n25q032a13",  0x20ba16,      0,  64 << 10,  64, ER_4K) },
> +    { INFO("n25q064a11",  0x20bb17,      0,  64 << 10, 128, ER_4K) },
> +    { INFO("n25q064a13",  0x20ba17,      0,  64 << 10, 128, ER_4K) },
> +    { INFO("n25q128a11",  0x20bb18,      0,  64 << 10, 256, ER_4K) },
> +    { INFO("n25q128a13",  0x20ba18,      0,  64 << 10, 256, ER_4K) },
> +    { INFO("n25q256a11",  0x20bb19,      0,  64 << 10, 512, ER_4K) },
> +    { INFO("n25q256a13",  0x20ba19,      0,  64 << 10, 512, ER_4K) },
>

Thanks for the patch. Ive copied this hunk to LKML to see what they
think (I got one reply but off list unfortunately) about synchronising
with us.

Id like to give it a few days to see what they say before we merge
this. Ideally we have agreement between the two source trees, so we
can continue the copy-paste based update strategy.

Regards,
Peter

>      /* Spansion -- single (large) sector size only, at least
>       * for the chips listed here (without boot sectors).
> --
> 1.7.11.5
>
>