[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some func
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions |
|
Date: |
Wed, 19 Jun 2013 12:17:59 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 |
18.06.2013 07:45, liguang wrote:
> last parameters of vnc_listen_read,vnc_connect are bool,
> so pass 'false/true' instead of '0/1' for them.
>
> Reviewed-by: Andreas Färber <address@hidden>
> Signed-off-by: liguang <address@hidden>
I think I'll apply my version instead, -- which converts remaining arguments
of functions your patch touches (so that we don't have this:
> - vnc_connect(vs, csock, 0, 0);
> + vnc_connect(vs, csock, 0, false);
where 3rd argument is also a bool), and which combines your patches 1/5
and 2/5 into one.
I'll resend it again in a top-level message.
Thanks,
/mjt