Re: [Qemu-trivial] [Qemu-devel] [PATCH] Spelling fixes

[Corentin Chary]

The comments (and most of the code) are from libvncserver (and,
earlier, from "THE 'ZYWRLE' VNC CODEC SOURCE CODE. " as described in
the header):

http://fastdroid-vnc.googlecode.com/svn-history/r3/trunk/LibVNCServer-0.9.7/libvncserver/zywrletemplate.c

On Mon, Jul 8, 2013 at 5:43 AM, Stefan Weil <address@hidden> wrote:
> Am 08.07.2013 00:32, schrieb Peter Maydell:
>> On 7 July 2013 23:05, Alex Bligh <address@hidden> wrote:
>>>
>>> --On 7 July 2013 22:25:02 +0200 Stefan Weil <address@hidden> wrote:
>>>
>>>> --- a/ui/vnc-enc-zywrle.h
>>>> +++ b/ui/vnc-enc-zywrle.h
>>>> @@ -305,9 +305,9 @@ static inline void harr(int8_t *px0, int8_t *px1)
>>>>     |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1
>>>>
>>>>   In this method, H/L and X0/X1 is always same position.
>>>> - This lead us to more speed and less memory.
>>>> - Of cause, the result of both method is quite same
>>>> - because it's only difference that coefficient position.
>>>> + This leads us to more speed and less memory.
>>>> + Of course, the result of both methods is quite same
>>>> + because its only difference is that coefficient position.
>>>>  */
>>>>  static inline void wavelet_level(int *data, int size, int l, int
>>>> skip_pixel)  {
>>>
>>> If we're doing spelling/grammar fixes, that should be "is quite the same"
>>> and "that of coefficient position".
>> "is quite the same" isn't idiomatic English either. I can't
>> tell if the author meant "is quite similar" or "is exactly
>> the same", so we probably shouldn't change the text unless
>> we can work out which one is right...
>>
>> -- PMM
>
> Thank you for both answers. Even as non native speaker
> I was aware that this part still did not sound like correct English,
> but I restricted my modifications to those parts where I was sure.
>
> Let's ask the original author Corentin Chary...
>
> Regards
> Stefan W.
>



-- 
Corentin Chary
http://xf.iksaif.net