qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable


From: Aurelien Jarno
Subject: Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
Date: Mon, 29 Jul 2013 00:37:10 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
> 
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  target-mips/op_helper.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 5cf1c3f..b828375 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
>  void helper_fork(target_ulong arg1, target_ulong arg2)
>  {
>      // arg1 = rt, arg2 = rs
> -    arg1 = 0;
>      // TODO: store to TC register
>  }
>  

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]