[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-ga: build it even if !syste
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-ga: build it even if !system |
|
Date: |
Wed, 31 Jul 2013 16:24:43 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7 |
31.07.2013 16:03, Andreas Färber wrote:
> Am 31.07.2013 13:05, schrieb Peter Maydell:
>>> Actually the more I think about it... Maybe it shouldn't depend
>>> on --enable-tools either, but should be an independent option.
>>> Because it isn't really a tool.
>>
>> This seems to me to be unnecessarily breaking things down
>> into very finely divided categories. I think putting it
>> in --enable-tools is fine.
>
> I disagree. Think about building a Windows guest agent: You don't need
> qemu-img (tools) on a Windows guest, and mjt is right that it shouldn't
> be coupled to building any qemu-system-*.
It's not a tool, but indeed that's unnecessary too fine-grained.
I'm not sure which way is preferrable :)
> However it looks as if the linux/bsd/solaris checks got lost in the patch?
No, the new place is already within linux/bsd/solaris conditional.
/mjt