qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: fix get_physical_ad


From: James Hogan
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error
Date: Wed, 28 Aug 2013 09:28:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 27/08/13 20:48, Richard Henderson wrote:
> On 08/27/2013 09:48 AM, Yongbok Kim wrote:
>>  #if 0
>> -    qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
>> +    qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
>>              address, rw, access_type, *physical, *prot, ret);
>>  #endif
> 
> While by itself correct, consider converting this to the trace infrastructure
> (with uint64_t instead of hwaddr).
> 
> If it's not worth a trace, it's probably not worth keeping at all.

True. I suspect it isn't worth a trace (I just happened to be modifying
that function so tried it out to test my changes - and anybody doing
that can easily add a temporary qemu_log/fprintf message themselves).

Cheers
James




reply via email to

[Prev in Thread] Current Thread [Next in Thread]