[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak
From: |
Gabriel Kerneis |
Subject: |
[Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak |
Date: |
Wed, 11 Sep 2013 14:41:52 +0100 |
The variable extra_cflags needs to be quoted in config-host.mak,
in particular because it might contain parentheses that would
otherwise be interpreted by the shell when reloading the file.
For instance, if one wants to define some attribute with configure:
./configure --extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))'"
A more robust approach would be to escape every variable properly, but
there is no portable equivalent to bash's "printf %q" solution. The
current patch, while not bullet-proof, works well in the common case.
Signed-off-by: Gabriel Kerneis <address@hidden>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index e989609..23114de 100755
--- a/configure
+++ b/configure
@@ -3681,7 +3681,7 @@ if test "$mingw32" = "no" ; then
echo "qemu_localstatedir=$local_statedir" >> $config_host_mak
fi
echo "qemu_helperdir=$libexecdir" >> $config_host_mak
-echo "extra_cflags=$EXTRA_CFLAGS" >> $config_host_mak
+echo "extra_cflags=\"$EXTRA_CFLAGS\"" >> $config_host_mak
echo "extra_ldflags=$EXTRA_LDFLAGS" >> $config_host_mak
echo "qemu_localedir=$qemu_localedir" >> $config_host_mak
echo "libs_softmmu=$libs_softmmu" >> $config_host_mak
--
1.7.10.4
- [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak,
Gabriel Kerneis <=
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Paolo Bonzini, 2013/09/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak, Gabriel Kerneis, 2013/09/11
- Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak, Eric Blake, 2013/09/11