[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PULL 00/15] trivial patches for 2013-09
From: |
Stefan Weil |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14 |
Date: |
Tue, 17 Sep 2013 18:38:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
Am 17.09.2013 17:06, schrieb Anthony Liguori:
> On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <address@hidden> wrote:
>> Just a bit late but here's the next trivial-patches pull request.
>>
>> Thanks,
> Breaks the build:
>
> /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’:
> /home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> /home/anthony/git/qemu/cpu-exec.c:202:28: error: argument ‘env’ might
> be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
> cc1: all warnings being treated as errors
>
> I think it's one of the warning patches from Stefan. I cannot bisect
> here. My gcc info is below:
Yes, it's the new -Wextra compiler (see "configure: Enable extra
compiler warnings").
Some versions of gcc complain about this code in cpu-exec.c:
/* Reload env after longjmp - the compiler may have smashed all
* local variables as longjmp is marked 'noreturn'. */
cpu = current_cpu;
env = cpu->env_ptr;
I think that lines can be simply removed (which also fixes the warning).
Please apply the trivial patches without my -Wextra patch or wait until
I have sent a patch to fix cpu-exec.c.
Regards
Stefan
- [Qemu-trivial] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning, (continued)
- [Qemu-trivial] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning, Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 13/15] Makefile: Remove some more files when cleaning, Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 06/15] MAINTAINERS: Add missing entry to filelist for TCI target, Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 09/15] trace-events: Clean up with scripts/cleanup-trace-events.pl again, Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 14/15] tcg-sparc: Fix parenthesis warning, Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 12/15] target-i386: Fix segment cache dump, Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 08/15] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions), Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 04/15] *-user: Fix typo in comment (ulocking -> unlocking), Michael Tokarev, 2013/09/14
- [Qemu-trivial] [PULL 15/15] configure: Enable extra compiler warnings, Michael Tokarev, 2013/09/14
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14, Anthony Liguori, 2013/09/17