[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definition
|
From: |
Fabien Chouteau |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands |
|
Date: |
Thu, 26 Sep 2013 16:50:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
On 09/26/2013 02:05 AM, Peter Maydell wrote:
> On 26 September 2013 01:29, Fabien Chouteau <address@hidden> wrote:
>> On 09/25/2013 05:51 PM, Peter Maydell wrote:
>>> On 26 September 2013 00:38, Fabien Chouteau <address@hidden> wrote:
>>> It doesn't matter very much, but monitor.h seems the obvious
>>> place. You probably don't want qom/cpu.h to have to drag in
>>> monitor.h so a 'struct MonitorDef;' forward declaration in cpu.h
>>> will let you avoid that (we do that already for a few other structs).
>>
>> I think that's what I did. I think the problem was to include
>> 'monitor.h' in 'target-*/cpu.c'.
>
> Why doesn't that work?
>
The problem is use of 'target_long' in 'monitor.h'.
--
Fabien Chouteau
- [Qemu-trivial] [PATCH 0/3] Few minor improvements of monitor disas command (v2), Fabien Chouteau, 2013/09/24
- [Qemu-trivial] [PATCH 2/3] Improve Monitor disas with symbol lookup, Fabien Chouteau, 2013/09/24
- [Qemu-trivial] [PATCH 1/3] Fix coding style, Fabien Chouteau, 2013/09/24
- [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Fabien Chouteau, 2013/09/24
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/24
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Fabien Chouteau, 2013/09/25
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/25
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Fabien Chouteau, 2013/09/25
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/25
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands,
Fabien Chouteau <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/26