qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] qemu-char: Fix potential out of bounds access


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH] qemu-char: Fix potential out of bounds access to local arrays
Date: Wed, 02 Oct 2013 20:34:12 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9

01.10.2013 01:04, Stefan Weil wrote:
Latest gcc-4.8 supports a new option -fsanitize=address which activates
an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation
very early because two character arrays of size 8 are potentially written
with 9 bytes.

Commit 6ea314d91439741e95772dfbab98b4135e04bebb added the code.

There is no obvious reason why width or height could need 8 characters,
so reduce it to 7 characters which together with the terminating '\0'
fit into the arrays.

A good one.

Thanks, applied to the trivial patches queue.

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]