[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] configure: create fsdev/ directory
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [PATCH] configure: create fsdev/ directory |
|
Date: |
Sun, 13 Oct 2013 09:01:41 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 12/10/2013 21:05, Michael Tokarev ha scritto:
> I considered doing it there initially, but decided to add it
> to the other place, because that's where virtfs variable
> is set. The place you're referring to will need to have a
> condition `if' based on $virtfs value.
It's harmless to create a directory that won't be used.
> Also, there are other places below this virtfs test (which I
> modified) which runs mkdir (dtc, pixman), so this is not
> something unusual.
I didn't check the code, and dtc+pixman are both submodules so there may
be something special there. But in general, let's avoid the "it's bad
so it's okay to make it worse" argument.
Paolo