qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] better interpreter specification


From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] better interpreter specification for scripts
Date: Fri, 15 Nov 2013 08:01:37 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

Am 15.11.2013 07:51, schrieb Luigi Rizzo:
some of the new scripts in scripts/ specify a interpreter path
which is not always pointing to the right place.
I see that an alternative format is also being used
        #!/usr/bin/env <interpreter_name>
which seems to work better.

The patch below is merely to let master compile on FreeBSD,
but there are other offending files that can be found with
 grep '#!' scripts/*

There is no need to fix acpi_extract.py here, because the error is in hw/i386/Makefile.objs:

It should call the script using $(PYTHON). Otherwise it won't use the Python interpreter
which was specified when configure was called with --python=PYTHON-INTERPRETER.

wrong: hw/i386/Makefile.objs:  $(call quiet-command, $(SRC_PATH)/scripts/...

correct: hw/i386/Makefile.objs:  $(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/...

This should be fixed for QEMU 1.7 (send patch with [PATCH for 1.7]).

Stefan


Signed-off-by: Luigi Rizzo <address@hidden>
---
 scripts/acpi_extract.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py
index 22ea468..66c1b3e 100755
--- a/scripts/acpi_extract.py
+++ b/scripts/acpi_extract.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
 # Copyright (C) 2011 Red Hat, Inc., Michael S. Tsirkin <address@hidden>
 #
 # This program is free software; you can redistribute it and/or modify
--
1.8.1.2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]