[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] linux-user: fixed getsockopt
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] linux-user: fixed getsockopt() optlen |
|
Date: |
Wed, 15 Jan 2014 23:37:35 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
12.01.2014 23:07, Peter Maydell wrote:
> On 11 January 2014 09:34, <address@hidden> wrote:
>> From: Pavel Zbitskiy <address@hidden>
>>
>> optlen parameter of getsockopt() of type socklen_t* was read into
>> variable of type socklen_t, that caused zeroing out of upper 4 bytes
>> when running s390x on top of x86_64. This patch changes optlen type
>> to abi_ulong.
>
> This patch and patch 3 are correct fixes, but shouldn't we be
> more generally using abi_ulong for every argument we read from
> the guest in do_socketcall() ?
I think the current fix is worth to apply anyway, regareless of
further possible rework.
Thanks,
/mjt