Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: helpfully output package names for some missing dependencies.

[Stefan Weil]

Hi Steward,

Am 23.01.2014 05:54, schrieb Stewart Smith:
> This just makes it a tiny bit easier for new developers to get started
> by making it easy to see what package they need to install to get
> the dependency.
> 
> Signed-off-by: Stewart Smith <address@hidden>
> ---
>  configure | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 3782a6a..87303f6 100755
> --- a/configure
> +++ b/configure
> @@ -1532,7 +1532,9 @@ EOF
>          :
>      else
>          error_exit "zlib check failed" \
> -            "Make sure to have the zlib libs and headers installed."
> +            "Make sure to have the zlib libs and headers installed." \
> +            "Debian/Ubuntu: zlib1g-dev" \
> +            "Fedora/RHEL: zlib-devel"
>      fi
>  fi

Removing that zlib check is on my private todo list since QEMU uses
glib2, because glib2 already depends on zlib.


>  libs_softmmu="$libs_softmmu -lz"
> @@ -2348,7 +2350,9 @@ if $pkg_config --atleast-version=$glib_req_ver 
> gthread-2.0; then
>      LIBS="$glib_libs $LIBS"
>      libs_qga="$glib_libs $libs_qga"
>  else
> -    error_exit "glib-$glib_req_ver required to compile QEMU"
> +    error_exit "glib-$glib_req_ver required to compile QEMU."\
> +               "Debian/Ubuntu: libglib2.0-dev" \
> +               "Fedora/RHEL: glib2-devel"
>  fi
>  
>  ##########################################
> @@ -2380,6 +2384,8 @@ else
>      error_exit "pixman not present. Your options:" \
>          "  (1) Preferred: Install the pixman devel package (any recent" \
>          "      distro should have packages as Xorg needs pixman too)." \
> +     "      Ubuntu/Debian: libpixman-1-dev" \
> +        "      Fedora/RHEL: pixman-devel"\
>          "  (2) Fetch the pixman submodule, using:" \
>          "      git submodule update --init pixman"
>    fi
> @@ -2656,6 +2662,8 @@ EOF
>      # have neither and want - prompt for system/submodule install
>      error_exit "DTC not present. Your options:" \
>          "  (1) Preferred: Install the DTC devel package" \
> +     "      Ubuntu/Debian: libfdt-dev" \

The previous line uses a tab character. Replace it by blanks.

Here a small hint might by useful because searching for 'DTC' packages
will usually fail. What about writing "DTC (libfdt) devel package"?

> +        "      Fedora/RHEL: libfdt-devel" \
>          "  (2) Fetch the DTC submodule, using:" \
>          "      git submodule update --init dtc"
>    else
> 

I'm not sure whether the file 'configure' is the right place for the
precise package information. Here are some thoughts:

* Those help messages are only useful for Debian / Fedore based Linux
  distributions, but not for OpenSuSE and definitely not for other
  hosts (Mac OS X, Windows, BSD).

* They only cover a very limited set of packages. For a really useful
  QEMU, lots of more packages are needed.

* Package names are not really good interfaces because they tend to
  change over time.

My personal impression is that the current hints in configure are
sufficient (with the one exception DTC) and that the QEMU wiki is a
better place to document build dependencies for the different platforms.

Cheers
Stefan