[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 07/12] hw/intc/openpic: Avoid shifting left into s
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-trivial] [PATCH 07/12] hw/intc/openpic: Avoid shifting left into sign bit |
|
Date: |
Mon, 10 Mar 2014 19:10:43 +0000 |
Add U suffix to avoid undefined behaviour.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/intc/openpic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c
index 7df72f4..cfd7f06 100644
--- a/hw/intc/openpic.c
+++ b/hw/intc/openpic.c
@@ -123,7 +123,7 @@ static FslMpicInfo fsl_mpic_42 = {
#define TCCR_TOG 0x80000000 /* toggles when decrement to zero */
#define IDR_EP_SHIFT 31
-#define IDR_EP_MASK (1 << IDR_EP_SHIFT)
+#define IDR_EP_MASK (1U << IDR_EP_SHIFT)
#define IDR_CI0_SHIFT 30
#define IDR_CI1_SHIFT 29
#define IDR_P1_SHIFT 1
@@ -220,7 +220,7 @@ typedef struct IRQSource {
} IRQSource;
#define IVPR_MASK_SHIFT 31
-#define IVPR_MASK_MASK (1 << IVPR_MASK_SHIFT)
+#define IVPR_MASK_MASK (1U << IVPR_MASK_SHIFT)
#define IVPR_ACTIVITY_SHIFT 30
#define IVPR_ACTIVITY_MASK (1 << IVPR_ACTIVITY_SHIFT)
#define IVPR_MODE_SHIFT 29
--
1.9.0
- Re: [Qemu-trivial] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit, (continued)
- [Qemu-trivial] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 05/12] target-mips: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 07/12] hw/intc/openpic: Avoid shifting left into sign bit,
Peter Maydell <=
- [Qemu-trivial] [PATCH 09/12] tests/libqos/pci-pc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 01/12] target-i386: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 10/12] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic, Peter Maydell, 2014/03/10
- Re: [Qemu-trivial] [PATCH 00/12] Avoid shifting left into sign bit, Michael S. Tsirkin, 2014/03/10