|
From: | Sebastian Huber |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows |
Date: | Wed, 12 Mar 2014 10:48:21 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Hello, On 2014-03-02 16:56, Sebastian Huber wrote:
On 03/02/2014 02:17 PM, Michael Tokarev wrote:26.02.2014 11:53, Sebastian Huber wrote:Ping.There was another comment on this, about the first hunk, see https://lists.gnu.org/archive/html/qemu-trivial/2014-02/msg00067.html Note that the comment below this line mentions the +1 which is being removed.I think I addressed this issue with the following sentence in the commit message of v2: "Use the GPTIMER counter value for tracing to avoid an overflow of the 32-bit value passed to trace_grlib_gptimer_enable()."
should I better split the patch into two parts? -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : address@hidden PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
[Prev in Thread] | Current Thread | [Next in Thread] |