[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for
From: |
Chen Gang |
Subject: |
Re: [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for target more nicely |
Date: |
Tue, 08 Apr 2014 15:18:44 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Thanks, and I will/should finish the left trivial patches within this
week (2014-04-13)
On 04/08/2014 03:04 PM, Michael Tokarev wrote:
> From: Chen Gang <address@hidden>
>
> When you ask for an accelerator not supported for your target, you get
> a bogus "accelerator does not exist" message:
>
> $ qemu-system-arm -machine none,accel=kvm
> KVM not supported for this target
> "kvm" accelerator does not exist.
> No accelerator found!
>
> Suppress it.
>
> Signed-off-by: Chen Gang <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 9975e5a..db9ea90 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2740,7 +2740,7 @@ static int configure_accelerator(QEMUMachine *machine)
> if (!accel_list[i].available()) {
> printf("%s not supported for this target\n",
> accel_list[i].name);
> - continue;
> + break;
> }
> *(accel_list[i].allowed) = true;
> ret = accel_list[i].init(machine);
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
- [Qemu-trivial] [PULL for-2.0 00/11] Trivial patches for 2014-04-08, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bit, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 04/11] net: Report error when device / hub combo is not found., Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for target more nicely, Michael Tokarev, 2014/04/08
- Re: [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for target more nicely,
Chen Gang <=
- [Qemu-trivial] [PULL 02/11] qga: trivial fix for unclear documentation of guest-set-time, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 07/11] xbzrle.c: Avoid undefined behaviour with signed arithmetic, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 06/11] int128.h: Avoid undefined behaviours involving signed arithmetic, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 03/11] configure: Fix indentation of help for --enable/disable-debug-info, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 09/11] configure: Remove redundant message for -Werror, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 11/11] Fix grammar in comment, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 08/11] scripts: add sample model file for Coverity Scan, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 10/11] doc: grammify "allows to", Michael Tokarev, 2014/04/08
- Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08, Peter Maydell, 2014/04/08