qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] qmp: use valid JSON in transaction example


From: Luiz Capitulino
Subject: Re: [Qemu-trivial] [PATCH] qmp: use valid JSON in transaction example
Date: Wed, 7 May 2014 10:37:15 -0400

On Tue,  6 May 2014 09:39:03 -0600
Eric Blake <address@hidden> wrote:

> Our example should use the correct quotes to match what someone
> could actually pass over the wire.
> 
> * qmp-commands.hx: Use correct JSON quotes.
> 
> Signed-off-by: Eric Blake <address@hidden>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..e20fcf0 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1165,19 +1165,19 @@ Example:
> 
>  -> { "execute": "transaction",
>       "arguments": { "actions": [
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
>                                           "snapshot-file": 
> "/some/place/my-image",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": 
> "myfile",
> +         { "type": "blockdev-snapshot-sync", "data" : { "node-name": 
> "myfile",
>                                           "snapshot-file": 
> "/some/place/my-image2",
>                                           "snapshot-node-name": "node3432",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
>                                           "snapshot-file": 
> "/some/place/my-image2",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
> +         { "type": "blockdev-snapshot-internal-sync", "data" : {
>                                           "device": "ide-hd2",
>                                           "name": "snapshot0" } } ] } }
>  <- { "return": {} }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]