Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] Support more than 255 cpus: runtime check

[Max Filippov]

On Thu, May 15, 2014 at 11:16 AM, Li, ZhenHua <address@hidden> wrote:
> Maybe it should be 4 bytes for 4096 (0x1000).

I'd say that 2 bytes should be enough, but actually I don't see
why anybody would care in that function how many bytes it is.

> On 05/13/2014 04:19 PM, Max Filippov wrote:
>>
>> On Tue, May 13, 2014 at 11:09 AM, Li, Zhen-Hua <address@hidden> wrote:
>>>
>>> From: "Li, ZhenHua" <address@hidden>
>>>
>>> There is some runtime check for max cpu count. Make them support 4096
>>> cpus.
>>>
>>> Signed-off-by: Li, ZhenHua <address@hidden>
>>> ---
>>>   hw/i386/acpi-build.c | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>>> index c98df88..5c3bf10 100644
>>> --- a/hw/i386/acpi-build.c
>>> +++ b/hw/i386/acpi-build.c
>>
>> [...]
>>
>>> @@ -680,7 +680,7 @@ build_append_notify_method(GArray *device, const char
>>> *name,
>>>       for (i = 0; i < count; i++) {
>>>           GArray *target = build_alloc_array();
>>>           build_append_nameseg(target, format, i);

BTW, build_append_nameseg also expects format string that makes a string of
4 characters, otherwise it asserts.

>>> -        assert(i < 256); /* Fits in 1 byte */
>>> +        assert(i < 4096); /* Fits in 1 byte */
>>
>> The comment is no longer true.
>> Also the function build_append_notify_method is called with format
>> argument
>> set to "CP%0.02X", looks like this should be changed to "CP%0.03X".

-- 
Thanks.
-- Max