[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Automatically select
|
From: |
Stefan Weil |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable |
|
Date: |
Mon, 19 May 2014 09:38:56 +0200 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 19.05.2014 08:19, schrieb Gerd Hoffmann:
> Hi,
>
>> +if test "$gtkabi" = ""; then
>> + # The GTK ABI was not specified explicitly, so try whether 2.0 is
>> available.
>> + # Use 3.0 as a fallback if that is available.
>> + if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then
>> + gtkabi=2.0
>> + elif $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then
>> + gtkabi=3.0
>> + else
>> + gtkabi=2.0
>> + fi
>> +fi
> Shouldn't we probe for gtk3 first?
>
> cheers,
> Gerd
That sounds reasonable, but would result in a non trivial change for all
developers who build on a system with both GTK versions. I tried to
preserve the current default (2.0) as far as possible.
Stefan