Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: Honour vlan/stack in hostfwd_remove commands

[Peter Maydell]

On 16 June 2014 16:47, Peter Maydell <address@hidden> wrote:
> The hostfwd_add and hostfwd_remove monitor commands allow the user
> to optionally specify a vlan/stack tuple. hostfwd_add honours this,
> but hostfwd_remove does not (it looks up the tuple but then ignores
> the SlirpState it has looked up and always uses the first stack
> in the list anyway). Correct this to honour what the user requested.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  net/slirp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 647039e..c171119 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -345,8 +345,7 @@ void net_slirp_hostfwd_remove(Monitor *mon, const QDict 
> *qdict)
>
>      host_port = atoi(p);
>
> -    err = slirp_remove_hostfwd(QTAILQ_FIRST(&slirp_stacks)->slirp, is_udp,
> -                               host_addr, host_port);
> +    err = slirp_remove_hostfwd(s->slirp, is_udp, host_addr, host_port);
>
>      monitor_printf(mon, "host forwarding rule for %s %s\n", src_str,
>                     err ? "not found" : "removed");
> --
> 1.9.2

Ping! (and cc trivial).

thanks
-- PMM