qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v4 0/8] don't use Yoda conditions


From: Gonglei (Arei)
Subject: Re: [Qemu-trivial] [PATCH v4 0/8] don't use Yoda conditions
Date: Wed, 6 Aug 2014 01:25:15 +0000

Hi,

> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
> >
> > v4:
> >  - trivial typo for patch 1/8 suggested by Eric, thanks.
> 
> Series: Reviewed-by: Eric Blake <address@hidden>
> 
> Adding qemu-trivial in cc.
> 
Thanks for review, Eric.

> > Gonglei (8):
> >   CODING_STYLE: Section about conditional statement
> >   usb: don't use 'Yoda conditions'
> >   audio: don't use 'Yoda conditions'
> >   isa-bus: don't use 'Yoda conditions'
> >   don't use 'Yoda conditions'
> >   spice: don't use 'Yoda conditions'
> >   vl: don't use 'Yoda conditions'
> >   vmxnet3: don't use 'Yoda conditions'
> >
> 
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

Best regards,
-Gonglei

reply via email to

[Prev in Thread] Current Thread [Next in Thread]