Re: [Qemu-trivial] [PATCH v6 08/10] tests/bios-tables-test: check the value returned by fopen()

[zhanghailiang]

On 2014/8/14 18:32, Michael S. Tsirkin wrote:
> On Thu, Aug 14, 2014 at 03:29:19PM +0800, zhanghailiang wrote:
> > The function fopen() may fail, so check its return value.
> >
> > Signed-off-by: zhanghailiang<address@hidden>
> > Signed-off-by: Li Liu<address@hidden>
> > Reviewed-by: Alex Bennée<address@hidden>
> > ---
> >   tests/bios-tables-test.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> > index 045eb27..28ec28d 100644
> > --- a/tests/bios-tables-test.c
> > +++ b/tests/bios-tables-test.c
> > @@ -790,6 +790,11 @@ int main(int argc, char *argv[])
> >       const char *arch = qtest_get_arch();
> >       FILE *f = fopen(disk, "w");
> >       int ret;
> > +
> > +    if (f == NULL) {
>
> if (!f) please

OK, i will modify it, thanks.

> > +        fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno));
> > +        return -1;
> > +    }
> >       fwrite(boot_sector, 1, sizeof boot_sector, f);
> >       fclose(f);
> >
> > --
> > 1.7.12.4
>
> .