[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [RESEND v2 1/3] query-memdev: fix potential memory leaks
From: |
Chen Fan |
Subject: |
[Qemu-trivial] [RESEND v2 1/3] query-memdev: fix potential memory leaks |
Date: |
Mon, 18 Aug 2014 14:46:33 +0800 |
Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Hu Tao <address@hidden>
---
numa.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/numa.c b/numa.c
index c78cec9..aa772aa 100644
--- a/numa.c
+++ b/numa.c
@@ -318,10 +318,11 @@ void memory_region_allocate_system_memory(MemoryRegion
*mr, Object *owner,
static int query_memdev(Object *obj, void *opaque)
{
MemdevList **list = opaque;
+ MemdevList *m = NULL;
Error *err = NULL;
if (object_dynamic_cast(obj, TYPE_MEMORY_BACKEND)) {
- MemdevList *m = g_malloc0(sizeof(*m));
+ m = g_malloc0(sizeof(*m));
m->value = g_malloc0(sizeof(*m->value));
@@ -369,6 +370,9 @@ static int query_memdev(Object *obj, void *opaque)
return 0;
error:
+ g_free(m->value);
+ g_free(m);
+
return -1;
}
--
1.9.3
- [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev, Chen Fan, 2014/08/18
- [Qemu-trivial] [RESEND v2 2/3] qom/object.c: fix string_output_get_string() memory leak, Chen Fan, 2014/08/18
- [Qemu-trivial] [RESEND v2 1/3] query-memdev: fix potential memory leaks,
Chen Fan <=
- [Qemu-trivial] [RESEND v2 3/3] hmp: fix MemdevList memory leak, Chen Fan, 2014/08/18
- Re: [Qemu-trivial] [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev, address@hidden, 2014/08/24
- Re: [Qemu-trivial] [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev, address@hidden, 2014/08/27
- Re: [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev, Michael Tokarev, 2014/08/29