Re: [Qemu-trivial] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

[Dmitry Fleytman]

On Aug 24, 2014, at 16:10 PM, Michael Tokarev <address@hidden> wrote:

> 24.08.2014 16:28, Dmitry Fleytman wrote:
> 
>> Hi Michael,
>> 
>> I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me.
> 
> Maybe you can add yourself to MAINTAINERS file as well? :)

Yes, this should be done.
How we do this? Should I send a patch for MAINTAINETRS?


> I dunno if that's actually needed, but at least this should
> stop "strain" patches like this to be sent to -trivial alone... ;)
> 
>> I think this patch is correct and needed.
>> 
>> As we saw a few times already on different operating systems,
>> vmware drivers expect short packets to be padded as required
>> by corresponding RFC. Therefore this patch fixes a real bug.
> 
> Okay, since there's no entry for vmxnet in MAINTAINERS, and with
> your blessing, and since this is a rather specific device which
> is not in common use, I'll apply it to -trivial, for now, unless
> you want to pick it up and send a pull request for it.


-trivial is good enough for this patch.

> 
> Given your description, I think it should be Cc: address@hidden
> 
>> Reviewed-by: Dmitry Fleytman <address@hidden>
> 
> Thanks,
> 
> /mjt