qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] numa: fix qerror_report_err not free issue


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH] numa: fix qerror_report_err not free issue
Date: Sat, 30 Aug 2014 09:26:01 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0

30.08.2014 07:36, john.liuli wrote:
> From: Li Liu <address@hidden>
> 
> All qerror_report_err returned none NULL pointers need to
> be freed, otherwise will cause memory leaking.
> 
> Although this place did not cause real memory leaking by exit,
> obviously it's not correct to use qerror_report_err
> without error_free it.

I don't thing there's any good reason to free resources like
this (freeing memory, closing files, etc) right before exit()
(esp. in error path).  The OS will do that for us in one go
much faster.

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]