[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to er
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report |
|
Date: |
Thu, 25 Sep 2014 06:35:33 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/25/2014 03:46 AM, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> util/osdep.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/util/osdep.c b/util/osdep.c
> index b2bd154..7f6e483 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -401,9 +401,9 @@ void fips_set_state(bool requested)
> #endif /* __linux__ */
>
> #ifdef _FIPS_DEBUG
> - fprintf(stderr, "FIPS mode %s (requested %s)\n",
> - (fips_enabled ? "enabled" : "disabled"),
> - (requested ? "enabled" : "disabled"));
> + error_report("FIPS mode %s (requested %s)",
> + (fips_enabled ? "enabled" : "disabled"),
> + (requested ? "enabled" : "disabled"));
Do we really want debugging messages going through error_report()? This
may be one hunk we don't want.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature