Re: [Qemu-trivial] [Qemu-devel] [PATCH] oslib-posix: change free to g_free

[zhanghailiang]

On 2014/10/11 10:54, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> The caller of qemu_vfree() maybe not check whether parameter
> ptr pointer is NULL or not, such as vpc_open().
> Using g_free() is more safe.

It seems that free(NULL) is harmless.

From section 7.20.3.2/2 of the C99 standard:
The free function causes the space pointed to by ptr to be deallocated, that is,
made available for further allocation. If ptr is a null pointer, no action 
occurs.

> Signed-off-by: Gonglei <address@hidden>
> ---
>   util/oslib-posix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 016a047..ca435d0 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -153,7 +153,7 @@ void *qemu_anon_ram_alloc(size_t size)
>   void qemu_vfree(void *ptr)
>   {
>       trace_qemu_vfree(ptr);
> -    free(ptr);
> +    g_free(ptr);
>   }
>
>   void qemu_anon_ram_free(void *ptr, size_t size)