qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove


From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'
Date: Thu, 23 Oct 2014 12:05:48 +0100

On 23 October 2014 11:27, Michael Tokarev <address@hidden> wrote:
> On 10/23/2014 02:09 PM, Peter Maydell wrote:
>> On 23 October 2014 10:02, Peter Maydell <address@hidden> wrote:
>>> On 23 October 2014 09:09, Michael Tokarev <address@hidden> wrote:
>>>> Applied to trivial (with subject fixup), thanks!
>>>
>>> Please don't -- as I said, I have a libvixl update in my queue,
>>> and these will conflict. I'll apply an appropriate variation of
>>> this patch to my target-arm tree.
>>
>> ...or maybe I just *thought* I'd said that, since I can't find
>> a mail in this thread where I did; sorry.
>
> You did, in a "v2" version.  Which I overlooked really, and tried
> to apply the original v1 (which has you reviewed-by as a temp.
> workaround).  Oh well.. :)

Oh yes. I actually prefer v1, so I've applied it (with a tweaked
commit message) to target-arm.next. When libvixl 1.7 appears we
can just drop this change.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]