[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp/smbd: disable printer in s
Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp/smbd: disable printer in smb config
Mon, 03 Nov 2014 18:59:21 +0100
KMail/4.13.3 (Linux/3.17.0-rc4-custom-00168-g7ec62d4; KDE/4.14.2; x86_64; ; )
On Monday 03 November 2014 17:15:24 Michael Tokarev wrote:
> BTW, I'm not sure `socket address' paraameter is relevant in this context
> at all, -- smbd should not use it in inetd mode. It'd be interesting to
> know why this option is here to start with, and whenever we really need
> the new interfaces/bind-interfacs-only replacement.
The socket option is unused when QEMU invokes the command directly. The
only (weak) reason why it is still there is to ease testing, such that
you can simply use:
smbd -s smb.conf -p 1337
Without the socket option, I am afraid that you will accidentally expose
the very permissive share to the network.
So either append a comment explaining the above or just remove it. I am
fine with removing the interfaces option from this patch (or in a future
patch if you prefer that).