[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] l2tpv3: fix possible double free

From: zhanghailiang
Subject: Re: [Qemu-trivial] [PATCH] l2tpv3: fix possible double free
Date: Mon, 17 Nov 2014 13:13:23 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

On 2014/11/14 16:45, Paolo Bonzini wrote:

On 14/11/2014 02:39, zhanghailiang wrote:
freeaddrinfo(result) does not assign result = NULL, after frees it.
There will be a double free when it goes error case.
It is reported by covertiy.

Signed-off-by: zhanghailiang <address@hidden>
  net/l2tpv3.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 528d95b..f9e0c98 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -661,6 +661,7 @@ int net_init_l2tpv3(const NetClientOptions *opts,
          fd = -errno;
          error_report("l2tpv3_open : socket creation failed, errno = %d", -fd);
+        result = NULL;

You can just remove the call to freeaddrinfo().  I made the change and
applied the patch.

This is a better choice ;) Thanks.

          goto outerr;
      if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen)) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]