[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-iotests: Fix error message

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-iotests: Fix error message if which(1) not installed
Date: Mon, 17 Nov 2014 21:40:29 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 11/17/2014 07:49 PM, Fam Zheng wrote:
> When which(1) is not installed, we complain "perl not found" because
> it's the first set_prog_path check. The error message is misleading.
> Fix it by adding a check for which(1) in the beginning.

Why not instead change set_prog_path to use 'command -v' instead of
'which'?  As this is a bash script, we shouldn't need to shell out to an
optional package for something we can do natively.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]