[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] tests: Use "command -v" inste
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] tests: Use "command -v" instead of which(1) in shell scripts
Wed, 19 Nov 2014 14:07:09 +0000
On 19 November 2014 13:19, Eric Blake <address@hidden> wrote:
> Use of -a and -o in [] is a bit better, but I still HIGHLY recommend
> that constructs like this be rewritten as [ -n "$p" ] && [ -x "$p" ] for
> avoidance of confusion and prevention of copy-pasting the test to
> non-bash shells. But that would be a separate patch.
Yeah, this is one of those issues I tend to pick up in
patches which change our shell scripts, but we still have
a fair amount of existing code that isn't up to that standard.