qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.3] configure: Replace which


From: Amos Kong
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.3] configure: Replace which(1) with "has"
Date: Thu, 4 Dec 2014 14:40:35 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Dec 04, 2014 at 02:18:16PM +0800, Fam Zheng wrote:
> Using "has" is more slick because which(1) is not always there.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 47048f0..cae588c 100755
> --- a/configure
> +++ b/configure
> @@ -2727,7 +2727,7 @@ fi
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c >/dev/null 2>&1; then
> +        if has $c; then

we use self defined has function to check command in all other place
in configure. LGTM.

Reviewed-by: Amos Kong <address@hidden>

>              shacmd="$c"
>              break
>          fi
> -- 
> 1.9.3
> 

-- 
                        Amos.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]