|
| From: | Denis V. Lunev |
| Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH] kvm_irqchip_assign_irqfd: just set irqfd in case of kvm_irqfds_enabled() |
| Date: | Fri, 26 Dec 2014 13:16:10 +0300 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 26/12/14 13:00, Peter Maydell wrote:
On 26 December 2014 at 08:05, Tiejun Chen <address@hidden> wrote:We should avoid to set irqfd{} unconditionally. Signed-off-by: Tiejun Chen <address@hidden>Is there a hot path that we use this on such that the difference in code order matters at all? thanks -- PMM
IMHO the patch does not change anything even on hot-hot path.
the declaration 'struct kvm_irqfd irqfd = {};' will
result in memset inside.
Thus in order to achieve declared goal author should
declare
struct kvm_irqfd irqfd;
and perform
memset(&irqfd, 0, sizeof(irqfd));
later after the check.
Regards,
Den
| [Prev in Thread] | Current Thread | [Next in Thread] |