qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2] target-openrisc: bugfix for dec_sys to dec


From: Jia Liu
Subject: Re: [Qemu-trivial] [PATCH v2] target-openrisc: bugfix for dec_sys to decode instructions correctly
Date: Thu, 8 Jan 2015 09:54:45 +0800

Hi David,

On Wed, Jan 7, 2015 at 1:06 AM, David Morrison <address@hidden> wrote:
> Fixed the decoding of "system" instructions (starting with 0x2)
> in dec_sys() in translate.c.  In particular, the l.trap instruction
> is now correctly decoded, which enables for singlestepping and
> breakpoints to be set in GDB.
>
> Signed-off-by: David R. Morrison <address@hidden>
> ---
>  target-openrisc/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since previous version:
>   * Added 'signed-off-by' line; sorry to forget this before!
>
> diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
> index 407bd97..d36278f 100644
> --- a/target-openrisc/translate.c
> +++ b/target-openrisc/translate.c
> @@ -1320,7 +1320,7 @@ static void dec_sys(DisasContext *dc, uint32_t insn)
>  #ifdef OPENRISC_DISAS
>      uint32_t K16;
>  #endif
> -    op0 = extract32(insn, 16, 8);
> +    op0 = extract32(insn, 16, 10);

Thank you for pointing this.

Acked-by: Jia Liu <address@hidden>

>  #ifdef OPENRISC_DISAS
>      K16 = extract32(insn, 0, 16);
>  #endif
> --
> 2.2.1
>

Regards,
Jia



reply via email to

[Prev in Thread] Current Thread [Next in Thread]