qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: Need call


From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: Need call unlock_user() before go to failure return in default case
Date: Fri, 23 Jan 2015 10:01:36 +0000

On 23 January 2015 at 08:53, Chen Gang S <address@hidden> wrote:
> In abi_long do_ioctl_dm(), after calls lock_user(), it does not call
> unlock_user() before go to failure return in default case.
>
> Signed-off-by: Chen Gang <address@hidden>
> ---
>  linux-user/syscall.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index aaac6a2..290fdea 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3681,6 +3681,7 @@ static abi_long do_ioctl_dm(const IOCTLEntry *ie, 
> uint8_t *buf_temp, int fd,
>          }
>          default:
>              ret = -TARGET_EINVAL;
> +            unlock_user(argptr, guest_data, 0);
>              goto out;
>          }
>          unlock_user(argptr, guest_data, guest_data_size);
> --
> 1.9.3 (Apple Git-50)

Correct as far as it goes, but notice that we have the identical
bug in the other switch (ie->host_cmd) as well...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]