Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

[Peter Maydell]

On 23 January 2015 at 10:57, Chen Gang S <address@hidden> wrote:
>
> Thank you for all of your work.
>
> I plan to let qemu support tile architecture: "can let gcc run testsuite
> with qemu for tile". It is really hard to me, but I should try, it is my
> duty (I met it, and it's within my boarder, although no one pay for me).
> :-)

> Welcome any ideas, suggestions and completions by any members

My single biggest suggestion is to make sure you split the work
up so that you can post parts of it as you go along. Typically
for a target-*/ new port that looks something like
 * initial framework, but no instruction decode (so all instructions
   just throw an illegal instruction exception)
 * support for one or a few simple classes of instruction
 * gradually fill in the gaps of missing instructions

This way you get the benefit of code review on your early patches,
so you can write the later ones in line with the comments you
get on the first patches. We also get to review the code in
smaller and more manageable chunks.

I think the last target code to go in was target-tricore; you
could look back in the git history and the archives to get an
idea of how to structure the patchset and the kinds of review
comment that patchseries received.

thanks
-- PMM