[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] usb: Pair g_malloc() with g_
From: |
Gonglei |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] usb: Pair g_malloc() with g_free(), not free() |
Date: |
Thu, 29 Jan 2015 08:22:53 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2015/1/28 22:54, Markus Armbruster wrote:
> Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled
> and my "coverity: Model g_free() isn't necessarily free()" model patch
> applied.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/usb/desc-msos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c
> index 334d1ae..32c3600 100644
> --- a/hw/usb/desc-msos.c
> +++ b/hw/usb/desc-msos.c
> @@ -231,7 +231,7 @@ int usb_desc_msos(const USBDesc *desc, USBPacket *p,
> length = len;
> }
> memcpy(dest, buf, length);
> - free(buf);
> + g_free(buf);
>
> p->actual_length = length;
> return 0;
This patch had been added Gerd's usb queue :)
http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01998.html
Regards,
-Gonglei
- [Qemu-trivial] [PATCH 0/4] Pair g_malloc() with g_free(), not free(), Markus Armbruster, 2015/01/28
- [Qemu-trivial] [PATCH 2/4] qemu-option: Pair g_malloc() with g_free(), not free(), Markus Armbruster, 2015/01/28
- [Qemu-trivial] [PATCH 3/4] spapr_vio: Pair g_malloc() with g_free(), not free(), Markus Armbruster, 2015/01/28
- [Qemu-trivial] [PATCH 1/4] qemu-option: Replace pointless use of g_malloc0() by g_malloc(), Markus Armbruster, 2015/01/28
- [Qemu-trivial] [PATCH 4/4] usb: Pair g_malloc() with g_free(), not free(), Markus Armbruster, 2015/01/28
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] usb: Pair g_malloc() with g_free(), not free(),
Gonglei <=
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/4] Pair g_malloc() with g_free(), not free(), Eric Blake, 2015/01/28