qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignm


From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment
Date: Tue, 10 Feb 2015 10:19:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0


On 10/02/2015 10:15, Peter Maydell wrote:
> > -                        tb = (TranslationBlock *)(next_tb & ~TB_EXIT_MASK);
> >                          next_tb = 0;
> >                          break;
> >                      case TB_EXIT_ICOUNT_EXPIRED:
>
> True, I guess, but presumably this means we're doing unnecessary
> work in the next time round the loop re-finding the tb which we
> already had...

This is the TB_EXIT_REQUESTED case though: once the iothread runs who
knows what happens.  You might get an interrupt or a system reset that
diverts execution away from tb.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]