[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] target-ppc: Fix warnings from Sparse
From: |
Stefan Weil |
Subject: |
[Qemu-trivial] [PATCH] target-ppc: Fix warnings from Sparse |
Date: |
Sat, 7 Mar 2015 23:16:38 +0100 |
Sparse report:
target-ppc/mmu-hash64.c:353:9: warning: returning void-valued expression
target-ppc/mmu-hash64.c:620:9: warning: returning void-valued expression
Cc: Alexander Graf <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
Should we fix this kind of warnings? QEMU includes more than
60 lines of code which return a void expression.
Stefan
target-ppc/mmu-hash64.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c
index b0278c9..a9e1b4c 100644
--- a/target-ppc/mmu-hash64.c
+++ b/target-ppc/mmu-hash64.c
@@ -350,7 +350,7 @@ uint64_t ppc_hash64_start_access(PowerPCCPU *cpu,
target_ulong pte_index)
void ppc_hash64_stop_access(uint64_t token)
{
if (kvmppc_kern_htab) {
- return kvmppc_hash64_free_pteg(token);
+ kvmppc_hash64_free_pteg(token);
}
}
@@ -617,7 +617,8 @@ void ppc_hash64_store_hpte(CPUPPCState *env,
CPUState *cs = CPU(ppc_env_get_cpu(env));
if (kvmppc_kern_htab) {
- return kvmppc_hash64_write_pte(env, pte_index, pte0, pte1);
+ kvmppc_hash64_write_pte(env, pte_index, pte0, pte1);
+ return;
}
pte_index *= HASH_PTE_SIZE_64;
--
2.1.4
- [Qemu-trivial] [PATCH] target-ppc: Fix warnings from Sparse,
Stefan Weil <=